diff options
| author | Fred Isaman <iisaman@citi.umich.edu> | 2008-05-01 19:03:22 +0200 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2008-05-16 18:43:23 +0200 |
| commit | 38def50fabc479dc96ea6bd2cb2526e0dfc36fa4 (patch) | |
| tree | c7327131526e59b35f639af91dbea3075b20445e /fs/nfs | |
| parent | NFS: Ensure that 'noac' and/or 'actimeo=0' turn off attribute caching (diff) | |
| download | linux-38def50fabc479dc96ea6bd2cb2526e0dfc36fa4.tar.xz linux-38def50fabc479dc96ea6bd2cb2526e0dfc36fa4.zip | |
nfs: fix race in nfs_dirty_request
When called from nfs_flush_incompatible, the req is not locked, so
req->wb_page might be set to NULL before it is used by PageWriteback.
Signed-off-by: Fred Isaman <iisaman@citi.umich.edu>
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs/nfs')
| -rw-r--r-- | fs/nfs/write.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/write.c b/fs/nfs/write.c index 1ade11d1ba07..6d8ace3e3259 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c @@ -415,7 +415,7 @@ nfs_dirty_request(struct nfs_page *req) if (page == NULL || test_bit(PG_NEED_COMMIT, &req->wb_flags)) return 0; - return !PageWriteback(req->wb_page); + return !PageWriteback(page); } #if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4) |