diff options
| author | J. Bruce Fields <bfields@fieldses.org> | 2006-05-30 22:28:58 +0200 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2006-06-09 15:34:13 +0200 |
| commit | c04871e6345e4c6dfda564e302d7fd8c66420fd5 (patch) | |
| tree | 4b2a2b0fb5f282ffd5c95f64691476c647acd29f /fs/nfs | |
| parent | NFSv4: really return status from decode_recall_args() (diff) | |
| download | linux-c04871e6345e4c6dfda564e302d7fd8c66420fd5.tar.xz linux-c04871e6345e4c6dfda564e302d7fd8c66420fd5.zip | |
NFSv4: remove obviously bogus comparison from decode_getacl
We just set *acl_len to zero, and attrlen is unsigned, so this comparison
is clearly bogus. I have no idea what I was thinking.
Fixes a bug that caused getacl to fail over krb5p.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs/nfs')
| -rw-r--r-- | fs/nfs/nfs4xdr.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c index 7c5d70efe720..7e9a840057f2 100644 --- a/fs/nfs/nfs4xdr.c +++ b/fs/nfs/nfs4xdr.c @@ -3350,8 +3350,7 @@ static int decode_getacl(struct xdr_stream *xdr, struct rpc_rqst *req, attrlen, recvd); return -EINVAL; } - if (attrlen <= *acl_len) - xdr_read_pages(xdr, attrlen); + xdr_read_pages(xdr, attrlen); *acl_len = attrlen; } else status = -EOPNOTSUPP; |