diff options
| author | Thorsten Blum <thorsten.blum@toblux.com> | 2024-09-01 18:19:13 +0200 |
|---|---|---|
| committer | Anna Schumaker <anna.schumaker@oracle.com> | 2024-09-23 21:03:12 +0200 |
| commit | e343678ee990912a132e94236fe028efe78696b0 (patch) | |
| tree | 24ebff1419c99b02a41e83146422f8a449019154 /fs/nfs | |
| parent | nfs: Annotate struct nfs_cache_array with __counted_by() (diff) | |
| download | linux-e343678ee990912a132e94236fe028efe78696b0.tar.xz linux-e343678ee990912a132e94236fe028efe78696b0.zip | |
nfs: Remove unnecessary NULL check before kfree()
Since kfree() already checks if its argument is NULL, an additional
check before calling kfree() is unnecessary and can be removed.
Remove it and thus also the following Coccinelle/coccicheck warning
reported by ifnullfree.cocci:
WARNING: NULL check before some freeing functions is not needed
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
Diffstat (limited to 'fs/nfs')
| -rw-r--r-- | fs/nfs/read.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/nfs/read.c b/fs/nfs/read.c index a6103333b666..81bd1b9aba17 100644 --- a/fs/nfs/read.c +++ b/fs/nfs/read.c @@ -48,8 +48,7 @@ static struct nfs_pgio_header *nfs_readhdr_alloc(void) static void nfs_readhdr_free(struct nfs_pgio_header *rhdr) { - if (rhdr->res.scratch != NULL) - kfree(rhdr->res.scratch); + kfree(rhdr->res.scratch); kmem_cache_free(nfs_rdata_cachep, rhdr); } |