summaryrefslogtreecommitdiffstats
path: root/fs/nfsd/nfs4callback.c
diff options
context:
space:
mode:
authorDai Ngo <dai.ngo@oracle.com>2023-04-01 22:22:08 +0200
committerChuck Lever <chuck.lever@oracle.com>2023-04-04 15:55:27 +0200
commit7de82c2f36fb26aa78440bbf0efcf360b691d98b (patch)
tree47a5d5ef2c0e2caacc7a5e692008a5e7c372dab1 /fs/nfsd/nfs4callback.c
parentNFS: Remove "select RPCSEC_GSS_KRB5 (diff)
downloadlinux-7de82c2f36fb26aa78440bbf0efcf360b691d98b.tar.xz
linux-7de82c2f36fb26aa78440bbf0efcf360b691d98b.zip
NFSD: callback request does not use correct credential for AUTH_SYS
Currently callback request does not use the credential specified in CREATE_SESSION if the security flavor for the back channel is AUTH_SYS. Problem was discovered by pynfs 4.1 DELEG5 and DELEG7 test with error: DELEG5 st_delegation.testCBSecParms : FAILURE expected callback with uid, gid == 17, 19, got 0, 0 Signed-off-by: Dai Ngo <dai.ngo@oracle.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Fixes: 8276c902bbe9 ("SUNRPC: remove uid and gid from struct auth_cred") Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'fs/nfsd/nfs4callback.c')
-rw-r--r--fs/nfsd/nfs4callback.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index 2a815f5a52c4..4039ffcf90ba 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -946,8 +946,8 @@ static const struct cred *get_backchannel_cred(struct nfs4_client *clp, struct r
if (!kcred)
return NULL;
- kcred->uid = ses->se_cb_sec.uid;
- kcred->gid = ses->se_cb_sec.gid;
+ kcred->fsuid = ses->se_cb_sec.uid;
+ kcred->fsgid = ses->se_cb_sec.gid;
return kcred;
}
}