diff options
author | J. Bruce Fields <bfields@redhat.com> | 2011-09-19 21:07:41 +0200 |
---|---|---|
committer | J. Bruce Fields <bfields@redhat.com> | 2011-09-20 20:43:39 +0200 |
commit | 3d02fa29dec920c597dd7b7db608a4bc71f088ce (patch) | |
tree | 797913e7135502f54d52fa48f1956a8ff7b640dd /fs/nfsd/nfs4proc.c | |
parent | nfsd4: hash closed stateid's like any other (diff) | |
download | linux-3d02fa29dec920c597dd7b7db608a4bc71f088ce.tar.xz linux-3d02fa29dec920c597dd7b7db608a4bc71f088ce.zip |
nfsd4: fix open downgrade, again
Yet another open-management regression:
- nfs4_file_downgrade() doesn't remove the BOTH access bit on
downgrade, so the server's idea of the stateid's access gets
out of sync with the client's. If we want to keep an O_RDWR
open in this case, we should do that in the file_put_access
logic rather than here.
- We forgot to convert v4 access to an open mode here.
This logic has proven too hard to get right. In the future we may
consider:
- reexamining the lock/openowner relationship (locks probably
don't really need to take their own references here).
- adding open upgrade/downgrade support to the vfs.
- removing the atomic operations. They're redundant as long as
this is all under some other lock.
Also, maybe some kind of additional static checking would help catch
O_/NFS4_SHARE_ACCESS confusion.
Cc: stable@kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/nfs4proc.c')
0 files changed, 0 insertions, 0 deletions