diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2017-10-19 12:04:11 +0200 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2017-11-07 22:44:00 +0100 |
| commit | 256a89fa3deb6bb699b794e5bf00a72e2fe558b0 (patch) | |
| tree | 7fae8c6083d12226d1a4dd16857be83b750fabf1 /fs/nfsd/nfs4proc.c | |
| parent | fs, nfsd: convert nfs4_file.fi_ref from atomic_t to refcount_t (diff) | |
| download | linux-256a89fa3deb6bb699b794e5bf00a72e2fe558b0.tar.xz linux-256a89fa3deb6bb699b794e5bf00a72e2fe558b0.zip | |
nfds: avoid gettimeofday for nfssvc_boot time
do_gettimeofday() is deprecated and we should generally use time64_t
based functions instead.
In case of nfsd, all three users of nfssvc_boot only use the initial
time as a unique token, and are not affected by it overflowing, so they
are not affected by the y2038 overflow.
This converts the structure to timespec64 anyway and adds comments
to all uses, to document that we have thought about it and avoid
having to look at it again.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/nfs4proc.c')
| -rw-r--r-- | fs/nfsd/nfs4proc.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 7aff6d383d34..7d4495eac7a9 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -564,10 +564,11 @@ static void gen_boot_verifier(nfs4_verifier *verifier, struct net *net) /* * This is opaque to client, so no need to byte-swap. Use - * __force to keep sparse happy + * __force to keep sparse happy. y2038 time_t overflow is + * irrelevant in this usage. */ verf[0] = (__force __be32)nn->nfssvc_boot.tv_sec; - verf[1] = (__force __be32)nn->nfssvc_boot.tv_usec; + verf[1] = (__force __be32)nn->nfssvc_boot.tv_nsec; memcpy(verifier->data, verf, sizeof(verifier->data)); } |