diff options
| author | J. Bruce Fields <bfields@redhat.com> | 2014-05-08 17:19:41 +0200 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2014-05-21 17:11:21 +0200 |
| commit | 27b11428b7de097c42f205beabb1764f4365443b (patch) | |
| tree | 65f2c0c4be1291545d437f39d28e5f3ce2ca4180 /fs/nfsd/nfs4state.c | |
| parent | nfsd4: remove lockowner when removing lock stateid (diff) | |
| download | linux-27b11428b7de097c42f205beabb1764f4365443b.tar.xz linux-27b11428b7de097c42f205beabb1764f4365443b.zip | |
nfsd4: warn on finding lockowner without stateid's
The current code assumes a one-to-one lockowner<->lock stateid
correspondance.
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | fs/nfsd/nfs4state.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 89e42409b237..9a77a5a21557 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -4166,6 +4166,10 @@ static bool same_lockowner_ino(struct nfs4_lockowner *lo, struct inode *inode, c if (!same_owner_str(&lo->lo_owner, owner, clid)) return false; + if (list_empty(&lo->lo_owner.so_stateids)) { + WARN_ON_ONCE(1); + return false; + } lst = list_first_entry(&lo->lo_owner.so_stateids, struct nfs4_ol_stateid, st_perstateowner); return lst->st_file->fi_inode == inode; |