summaryrefslogtreecommitdiffstats
path: root/fs/nfsd/nfs4state.c
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2020-09-25 16:09:58 +0200
committerJ. Bruce Fields <bfields@redhat.com>2020-09-26 00:02:02 +0200
commit50747dd5e47bde3b7d7f839c84d0d3b554090497 (patch)
tree11b27675c740201b38db2612e795ea7b03047789 /fs/nfsd/nfs4state.c
parentnfsd: Cache R, RW, and W opens separately (diff)
downloadlinux-50747dd5e47bde3b7d7f839c84d0d3b554090497.tar.xz
linux-50747dd5e47bde3b7d7f839c84d0d3b554090497.zip
nfsd4: remove check_conflicting_opens warning
There are actually rare races where this is possible (e.g. if a new open intervenes between the read of i_writecount and the fi_fds). Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to '')
-rw-r--r--fs/nfsd/nfs4state.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 726046b6b370..a59551efd263 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -4955,7 +4955,6 @@ static int nfsd4_check_conflicting_opens(struct nfs4_client *clp,
writes--;
if (fp->fi_fds[O_RDWR])
writes--;
- WARN_ON_ONCE(writes < 0);
if (writes > 0)
return -EAGAIN;
spin_lock(&fp->fi_lock);