summaryrefslogtreecommitdiffstats
path: root/fs/nfsd/nfsd.h
diff options
context:
space:
mode:
authorChuck Lever <chuck.lever@oracle.com>2021-10-12 17:57:28 +0200
committerJ. Bruce Fields <bfields@redhat.com>2021-10-13 16:29:41 +0200
commitc44b31c263798ec34614dd394c31ef1a2e7e716e (patch)
tree3a6ed73ccf66ec7e4ec2ce54a32204c6e4e9c7e6 /fs/nfsd/nfsd.h
parentSUNRPC: Replace the "__be32 *p" parameter to .pc_decode (diff)
downloadlinux-c44b31c263798ec34614dd394c31ef1a2e7e716e.tar.xz
linux-c44b31c263798ec34614dd394c31ef1a2e7e716e.zip
SUNRPC: Change return value type of .pc_decode
Returning an undecorated integer is an age-old trope, but it's not clear (even to previous experts in this code) that the only valid return values are 1 and 0. These functions do not return a negative errno, rpc_stat value, or a positive length. Document there are only two valid return values by having .pc_decode return only true or false. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/nfsd.h')
-rw-r--r--fs/nfsd/nfsd.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h
index 6e8ad5f9757c..bfcddd4c7534 100644
--- a/fs/nfsd/nfsd.h
+++ b/fs/nfsd/nfsd.h
@@ -78,7 +78,7 @@ extern const struct seq_operations nfs_exports_op;
*/
struct nfsd_voidargs { };
struct nfsd_voidres { };
-int nfssvc_decode_voidarg(struct svc_rqst *rqstp,
+bool nfssvc_decode_voidarg(struct svc_rqst *rqstp,
struct xdr_stream *xdr);
int nfssvc_encode_voidres(struct svc_rqst *rqstp, __be32 *p);