diff options
author | J. Bruce Fields <bfields@redhat.com> | 2016-07-21 22:00:12 +0200 |
---|---|---|
committer | J. Bruce Fields <bfields@redhat.com> | 2016-08-04 23:11:52 +0200 |
commit | fa08139d5e02838ccabd9dcde22663d3b6780cad (patch) | |
tree | a7889d475555d0a593a536322de8d536dc772232 /fs/nfsd/vfs.c | |
parent | nfsd: clean up bad-type check in nfsd_create_locked (diff) | |
download | linux-fa08139d5e02838ccabd9dcde22663d3b6780cad.tar.xz linux-fa08139d5e02838ccabd9dcde22663d3b6780cad.zip |
nfsd: drop unnecessary MAY_EXEC check from create
We need an fh_verify to make sure we at least have a dentry, but actual
permission checks happen later.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/vfs.c')
-rw-r--r-- | fs/nfsd/vfs.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 1809624997f0..6666188c1138 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -1236,11 +1236,7 @@ nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp, if (isdotent(fname, flen)) return nfserr_exist; - /* - * Even though it is a create, first let's see if we are even allowed - * to peek inside the parent - */ - err = fh_verify(rqstp, fhp, S_IFDIR, NFSD_MAY_EXEC); + err = fh_verify(rqstp, fhp, S_IFDIR, NFSD_MAY_NOP); if (err) return err; |