summaryrefslogtreecommitdiffstats
path: root/fs/nfsd
diff options
context:
space:
mode:
authorBenny Halevy <bhalevy@panasas.com>2014-09-23 08:58:49 +0200
committerJ. Bruce Fields <bfields@redhat.com>2014-09-26 22:29:25 +0200
commit341b51df1fef0a39d792fb1c7d7856cf142627ab (patch)
treea9599a4b6b028103baa471dbb02f95ca3b6acad4 /fs/nfsd
parentnfsd: fix nfsd4_cb_recall_done error handling (diff)
downloadlinux-341b51df1fef0a39d792fb1c7d7856cf142627ab.tar.xz
linux-341b51df1fef0a39d792fb1c7d7856cf142627ab.zip
nfsd: do not clear rpc_resp in nfsd4_cb_done_sequence
This is incorrect when a callback is has to be restarted, in which case the XDR decoding of the second iteration will see a NULL cb argument. [hch: updated description] Signed-off-by: Benny Halevy <bhalevy@panasas.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd')
-rw-r--r--fs/nfsd/nfs4callback.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index 795e218a2a98..fc07084e8226 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -847,9 +847,6 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
rpc_wake_up_next(&clp->cl_cb_waitq);
dprintk("%s: freed slot, new seqid=%d\n", __func__,
clp->cl_cb_session->se_cb_seq_nr);
-
- /* We're done looking into the sequence information */
- task->tk_msg.rpc_resp = NULL;
}
}