diff options
| author | Jesper Juhl <jj@chaosbits.net> | 2011-03-06 00:30:35 +0100 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2011-03-07 18:05:14 +0100 |
| commit | 46d4cef9cf54f2f8b15216e3f6dad69750c69e0c (patch) | |
| tree | 43996e82b91a206579d57b99c620be40e78a3f95 /fs/nfsd | |
| parent | nfsd: kill unused macro definition (diff) | |
| download | linux-46d4cef9cf54f2f8b15216e3f6dad69750c69e0c.tar.xz linux-46d4cef9cf54f2f8b15216e3f6dad69750c69e0c.zip | |
NFSD, VFS: Remove dead code in nfsd_rename()
Currently we have the following code in fs/nfsd/vfs.c::nfsd_rename() :
...
host_err = nfsd_break_lease(odentry->d_inode);
if (host_err)
goto out_drop_write;
if (ndentry->d_inode) {
host_err = nfsd_break_lease(ndentry->d_inode);
if (host_err)
goto out_drop_write;
}
if (host_err)
goto out_drop_write;
...
'host_err' is guaranteed to be 0 by the time we test 'ndentry->d_inode'.
If 'host_err' becomes != 0 inside the 'if' statement, then we goto
'out_drop_write'. So, after the 'if' statement there is no way that
'host_err' can be anything but 0, so the test afterwards is just dead
code.
This patch removes the dead code.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd')
| -rw-r--r-- | fs/nfsd/vfs.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index da1d9701f8e4..9cc626b70fb6 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -1749,8 +1749,6 @@ nfsd_rename(struct svc_rqst *rqstp, struct svc_fh *ffhp, char *fname, int flen, if (host_err) goto out_drop_write; } - if (host_err) - goto out_drop_write; host_err = vfs_rename(fdir, odentry, tdir, ndentry); if (!host_err) { host_err = commit_metadata(tfhp); |