diff options
| author | Bill Wendling <morbo@google.com> | 2022-03-17 19:42:22 +0100 |
|---|---|---|
| committer | Chuck Lever <chuck.lever@oracle.com> | 2022-03-18 00:47:38 +0100 |
| commit | 4e1b04af4fe6679e63d1bc09f750424882ab701c (patch) | |
| tree | fd0535c74f1c9c8898b15d2da7277557d3fb5cb0 /fs/nfsd | |
| parent | NFSD: prevent integer overflow on 32 bit systems (diff) | |
| download | linux-4e1b04af4fe6679e63d1bc09f750424882ab701c.tar.xz linux-4e1b04af4fe6679e63d1bc09f750424882ab701c.zip | |
nfsd: use correct format characters
When compiling with -Wformat, clang emits the following warnings:
fs/nfsd/flexfilelayout.c:120:27: warning: format specifies type 'unsigned
char' but the argument has type 'int' [-Wformat]
"%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
~~~~ ^~~~~~~~~
%d
fs/nfsd/flexfilelayout.c:120:38: warning: format specifies type 'unsigned
char' but the argument has type 'int' [-Wformat]
"%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
~~~~ ^~~~~~~~~~~
%d
The types of these arguments are unconditionally defined, so this patch
updates the format character to the correct ones for ints and unsigned
ints.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Bill Wendling <morbo@google.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Tom Haynes <loghyr@hammerspace.com>
Diffstat (limited to 'fs/nfsd')
| -rw-r--r-- | fs/nfsd/flexfilelayout.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/flexfilelayout.c b/fs/nfsd/flexfilelayout.c index 2e2f1d5e9f62..070f90ed09b6 100644 --- a/fs/nfsd/flexfilelayout.c +++ b/fs/nfsd/flexfilelayout.c @@ -117,7 +117,7 @@ nfsd4_ff_proc_getdeviceinfo(struct super_block *sb, struct svc_rqst *rqstp, da->netaddr.addr_len = snprintf(da->netaddr.addr, FF_ADDR_LEN + 1, - "%s.%hhu.%hhu", addr, port >> 8, port & 0xff); + "%s.%d.%d", addr, port >> 8, port & 0xff); da->tightly_coupled = false; |