diff options
| author | Benny Halevy <bhalevy@panasas.com> | 2008-09-26 14:14:13 +0200 |
|---|---|---|
| committer | J. Bruce Fields <bfields@citi.umich.edu> | 2008-09-30 00:13:40 +0200 |
| commit | 97eb89bb0e5d9ab20dbc677cb18fad1421473287 (patch) | |
| tree | bdb97a295476b8f934c6295b4a2faa9511311b30 /fs/nfsd | |
| parent | SUNRPC: Clean up debug messages in rpcb_clnt.c (diff) | |
| download | linux-97eb89bb0e5d9ab20dbc677cb18fad1421473287.tar.xz linux-97eb89bb0e5d9ab20dbc677cb18fad1421473287.zip | |
nfsd: do_probe_callback should not clear rpc stats
Now that cb_stats are static (since commit
ff7d9756b501744540be65e172d27ee321d86103)
there's no need to clear them.
Initially I thought it might make sense to do
that every callback probing but since the stats
are per-program and they are shared between possibly
several client callback instances, zeroing them out
seems like the wrong thing to do.
Note that that commit also introduced a bug
since stats.program is also being cleared in the process
and it is not restored after the memset as it used to be.
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'fs/nfsd')
| -rw-r--r-- | fs/nfsd/nfs4callback.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index ab13e02c5683..f7c793a5b803 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -397,9 +397,6 @@ static int do_probe_callback(void *data) addr.sin_port = htons(cb->cb_port); addr.sin_addr.s_addr = htonl(cb->cb_addr); - /* Initialize rpc_stat */ - memset(args.program->stats, 0, sizeof(struct rpc_stat)); - /* Create RPC client */ client = rpc_create(&args); if (IS_ERR(client)) { |