diff options
author | Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com> | 2020-02-22 07:46:05 +0100 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2020-02-22 15:45:03 +0100 |
commit | c7849be9cc2dd2754c48ddbaca27c2de6d80a95d (patch) | |
tree | f097b2326d01be9834bcad66d20b1818464db2f1 /fs/no-block.c | |
parent | io_uring: prevent sq_thread from spinning when it should stop (diff) | |
download | linux-c7849be9cc2dd2754c48ddbaca27c2de6d80a95d.tar.xz linux-c7849be9cc2dd2754c48ddbaca27c2de6d80a95d.zip |
io_uring: fix __io_iopoll_check deadlock in io_sq_thread
Since commit a3a0e43fd770 ("io_uring: don't enter poll loop if we have
CQEs pending"), if we already events pending, we won't enter poll loop.
In case SETUP_IOPOLL and SETUP_SQPOLL are both enabled, if app has
been terminated and don't reap pending events which are already in cq
ring, and there are some reqs in poll_list, io_sq_thread will enter
__io_iopoll_check(), and find pending events, then return, this loop
will never have a chance to exit.
I have seen this issue in fio stress tests, to fix this issue, let
io_sq_thread call io_iopoll_getevents() with argument 'min' being zero,
and remove __io_iopoll_check().
Fixes: a3a0e43fd770 ("io_uring: don't enter poll loop if we have CQEs pending")
Signed-off-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/no-block.c')
0 files changed, 0 insertions, 0 deletions