summaryrefslogtreecommitdiffstats
path: root/fs/notify/inotify
diff options
context:
space:
mode:
authorAmir Goldstein <amir73il@gmail.com>2020-07-08 13:11:40 +0200
committerJan Kara <jack@suse.cz>2020-07-15 17:36:52 +0200
commit9991bb84b27a2594187898f261866cfc50255454 (patch)
tree14c649eff406a4d139bfdb16f38ea430f4cc69a2 /fs/notify/inotify
parentnfsd: use fsnotify_data_inode() to get the unlinked inode (diff)
downloadlinux-9991bb84b27a2594187898f261866cfc50255454.tar.xz
linux-9991bb84b27a2594187898f261866cfc50255454.zip
kernfs: do not call fsnotify() with name without a parent
When creating an FS_MODIFY event on inode itself (not on parent) the file_name argument should be NULL. The change to send a non NULL name to inode itself was done on purpuse as part of another commit, as Tejun writes: "...While at it, supply the target file name to fsnotify() from kernfs_node->name.". But this is wrong practice and inconsistent with inotify behavior when watching a single file. When a child is being watched (as opposed to the parent directory) the inotify event should contain the watch descriptor, but not the file name. Fixes: df6a58c5c5aa ("kernfs: don't depend on d_find_any_alias()...") Link: https://lore.kernel.org/r/20200708111156.24659-5-amir73il@gmail.com Acked-by: Tejun Heo <tj@kernel.org> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/notify/inotify')
0 files changed, 0 insertions, 0 deletions