summaryrefslogtreecommitdiffstats
path: root/fs/notify/mark.c
diff options
context:
space:
mode:
authorElena Reshetova <elena.reshetova@intel.com>2017-10-20 12:26:01 +0200
committerJan Kara <jack@suse.cz>2017-10-31 17:54:56 +0100
commit7761daa6a1599fa5479b8da367470f632a1927e0 (patch)
treef1ed23c310e76b1a78447268f9d16c153bb32721 /fs/notify/mark.c
parentfsnotify: Protect bail out path of fsnotify_add_mark_locked() properly (diff)
downloadlinux-7761daa6a1599fa5479b8da367470f632a1927e0.tar.xz
linux-7761daa6a1599fa5479b8da367470f632a1927e0.zip
fsnotify: convert fsnotify_group.refcnt from atomic_t to refcount_t
atomic_t variables are currently used to implement reference counters with the following properties: - counter is initialized to 1 using atomic_set() - a resource is freed upon counter reaching zero - once counter reaches zero, its further increments aren't allowed - counter schema uses basic atomic operations (set, inc, inc_not_zero, dec_and_test, etc.) Such atomic variables should be converted to a newly provided refcount_t type and API that prevents accidental counter overflows and underflows. This is important since overflows and underflows can lead to use-after-free situation and be exploitable. The variable fsnotify_group.refcnt is used as pure reference counter. Convert it to refcount_t and fix up the operations. Suggested-by: Kees Cook <keescook@chromium.org> Reviewed-by: David Windsor <dwindsor@gmail.com> Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/notify/mark.c')
0 files changed, 0 insertions, 0 deletions