diff options
| author | Shigeru Yoshida <syoshida@redhat.com> | 2022-08-23 16:46:25 +0200 |
|---|---|---|
| committer | Konstantin Komarov <almaz.alexandrovich@paragon-software.com> | 2022-09-30 16:39:52 +0200 |
| commit | caad9dd8792a2622737b7273cb34835fd9536cd2 (patch) | |
| tree | 36f634ace97b77d772f8812d6d88bc6ffcd4eed7 /fs/ntfs3 | |
| parent | fs/ntfs3: Fix memory leak on ntfs_fill_super() error path (diff) | |
| download | linux-caad9dd8792a2622737b7273cb34835fd9536cd2.tar.xz linux-caad9dd8792a2622737b7273cb34835fd9536cd2.zip | |
fs/ntfs3: Avoid UBSAN error on true_sectors_per_clst()
syzbot reported UBSAN error as below:
[ 76.901829][ T6677] ================================================================================
[ 76.903908][ T6677] UBSAN: shift-out-of-bounds in fs/ntfs3/super.c:675:13
[ 76.905363][ T6677] shift exponent -247 is negative
This patch avoid this error.
Link: https://syzkaller.appspot.com/bug?id=b0299c09a14aababf0f1c862dd4ebc8ab9eb0179
Fixes: a3b774342fa7 (fs/ntfs3: validate BOOT sectors_per_clusters)
Cc: Author: Randy Dunlap <rdunlap@infradead.org>
Reported-by: syzbot+35b87c668935bb55e666@syzkaller.appspotmail.com
Signed-off-by: Shigeru Yoshida <syoshida@redhat.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Diffstat (limited to 'fs/ntfs3')
| -rw-r--r-- | fs/ntfs3/super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index 569f38a2a51f..ff70e2a5f3ac 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -697,7 +697,7 @@ static u32 true_sectors_per_clst(const struct NTFS_BOOT *boot) if (boot->sectors_per_clusters <= 0x80) return boot->sectors_per_clusters; if (boot->sectors_per_clusters >= 0xf4) /* limit shift to 2MB max */ - return 1U << (0 - boot->sectors_per_clusters); + return 1U << -(s8)boot->sectors_per_clusters; return -EINVAL; } |