diff options
| author | Julia Lawall <julia@diku.dk> | 2008-03-05 00:21:05 +0100 |
|---|---|---|
| committer | Mark Fasheh <mfasheh@suse.com> | 2008-04-18 17:56:11 +0200 |
| commit | b1f3550fa1471b691ad6c2f35b5b22e93eaa5855 (patch) | |
| tree | 0d481a71d202883df116c55fdac4a4a60c4ca091 /fs/ocfs2/journal.c | |
| parent | ocfs2: Convert ocfs2 over to unlocked_ioctl (diff) | |
| download | linux-b1f3550fa1471b691ad6c2f35b5b22e93eaa5855.tar.xz linux-b1f3550fa1471b691ad6c2f35b5b22e93eaa5855.zip | |
ocfs2: Use BUG_ON
if (...) BUG(); should be replaced with BUG_ON(...) when the test has no
side-effects to allow a definition of BUG_ON that drops the code completely.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@ disable unlikely @ expression E,f; @@
(
if (<... f(...) ...>) { BUG(); }
|
- if (unlikely(E)) { BUG(); }
+ BUG_ON(E);
)
@@ expression E,f; @@
(
if (<... f(...) ...>) { BUG(); }
|
- if (E) { BUG(); }
+ BUG_ON(E);
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
Diffstat (limited to '')
| -rw-r--r-- | fs/ocfs2/journal.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c index bffd2d714f67..9698338adc39 100644 --- a/fs/ocfs2/journal.c +++ b/fs/ocfs2/journal.c @@ -717,8 +717,7 @@ int ocfs2_journal_load(struct ocfs2_journal *journal, int local) mlog_entry_void(); - if (!journal) - BUG(); + BUG_ON(!journal); osb = journal->j_osb; |