diff options
| author | Jesper Dangaard Brouer <netoptimizer@brouer.com> | 2013-10-31 22:10:55 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-11-05 02:01:29 +0100 |
| commit | 1ba3aab3033b464f352659720824d7124c21dbf9 (patch) | |
| tree | 3308ce1f1b158b507f802561cda5fde8866bf8e7 /fs/ocfs2 | |
| parent | Merge branch 'for-davem' of git://gitorious.org/linux-can/linux-can-next (diff) | |
| download | linux-1ba3aab3033b464f352659720824d7124c21dbf9.tar.xz linux-1ba3aab3033b464f352659720824d7124c21dbf9.zip | |
net: codel: Avoid undefined behavior from signed overflow
As described in commit 5a581b367 (jiffies: Avoid undefined
behavior from signed overflow), according to the C standard
3.4.3p3, overflow of a signed integer results in undefined
behavior.
To fix this, do as the above commit, and do an unsigned
subtraction, and interpreting the result as a signed
two's-complement number. This is based on the theory from
RFC 1982 and is nicely described in wikipedia here:
https://en.wikipedia.org/wiki/Serial_number_arithmetic#General_Solution
A side-note, I have seen practical issues with the previous logic
when dealing with 16-bit, on a 64-bit machine (gcc version
4.4.5). This were 32-bit, which I have not observed issues with.
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Jesper Dangaard Brouer <netoptimizer@brouer.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'fs/ocfs2')
0 files changed, 0 insertions, 0 deletions