diff options
author | Glauber Costa <glommer@parallels.com> | 2012-12-18 23:23:10 +0100 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-12-19 00:02:15 +0100 |
commit | ebe945c27628fca03723582eba138acc2e2f3d15 (patch) | |
tree | 5998e8dd874aedf3b8873d0ffeaf658d10505655 /fs/omfs | |
parent | kmem: add slab-specific documentation about the kmem controller (diff) | |
download | linux-ebe945c27628fca03723582eba138acc2e2f3d15.tar.xz linux-ebe945c27628fca03723582eba138acc2e2f3d15.zip |
memcg: add comments clarifying aspects of cache attribute propagation
This patch clarifies two aspects of cache attribute propagation.
First, the expected context for the for_each_memcg_cache macro in
memcontrol.h. The usages already in the codebase are safe. In mm/slub.c,
it is trivially safe because the lock is acquired right before the loop.
In mm/slab.c, it is less so: the lock is acquired by an outer function a
few steps back in the stack, so a VM_BUG_ON() is added to make sure it is
indeed safe.
A comment is also added to detail why we are returning the value of the
parent cache and ignoring the children's when we propagate the attributes.
Signed-off-by: Glauber Costa <glommer@parallels.com>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/omfs')
0 files changed, 0 insertions, 0 deletions