diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-09-22 22:45:18 +0200 |
|---|---|---|
| committer | Miklos Szeredi <mszeredi@redhat.com> | 2017-10-19 16:19:52 +0200 |
| commit | 0ce5cdc9d79277e55c3d80bf7d2b1adea2752078 (patch) | |
| tree | 63a093a0e017fd8064ee8a98de5f383593dcf42a /fs/overlayfs | |
| parent | ovl: add NULL check in ovl_alloc_inode (diff) | |
| download | linux-0ce5cdc9d79277e55c3d80bf7d2b1adea2752078.tar.xz linux-0ce5cdc9d79277e55c3d80bf7d2b1adea2752078.zip | |
ovl: Return -ENOMEM if an allocation fails ovl_lookup()
The error code is missing here so it means we return ERR_PTR(0) or NULL.
The other error paths all return an error code so this probably should
as well.
Fixes: 02b69b284cd7 ("ovl: lookup redirects")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs/overlayfs')
| -rw-r--r-- | fs/overlayfs/namei.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c index 654bea1a5ac9..e08164156cfe 100644 --- a/fs/overlayfs/namei.c +++ b/fs/overlayfs/namei.c @@ -635,6 +635,7 @@ struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry, } if (d.redirect) { + err = -ENOMEM; upperredirect = kstrdup(d.redirect, GFP_KERNEL); if (!upperredirect) goto out_put_upper; |