diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2014-03-21 02:10:51 +0100 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2014-03-31 01:18:51 +0200 |
commit | 38129a13e6e71f666e0468e99fdd932a687b4d7e (patch) | |
tree | 438e817fdf7d224f9fda1186eb24b1bbc37a4b5c /fs/pnode.h | |
parent | don't bother with propagate_mnt() unless the target is shared (diff) | |
download | linux-38129a13e6e71f666e0468e99fdd932a687b4d7e.tar.xz linux-38129a13e6e71f666e0468e99fdd932a687b4d7e.zip |
switch mnt_hash to hlist
fixes RCU bug - walking through hlist is safe in face of element moves,
since it's self-terminating. Cyclic lists are not - if we end up jumping
to another hash chain, we'll loop infinitely without ever hitting the
original list head.
[fix for dumb braino folded]
Spotted by: Max Kellermann <mk@cm4all.com>
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/pnode.h')
-rw-r--r-- | fs/pnode.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/pnode.h b/fs/pnode.h index 59e7eda1851e..fc28a27fa892 100644 --- a/fs/pnode.h +++ b/fs/pnode.h @@ -36,8 +36,8 @@ static inline void set_mnt_shared(struct mount *mnt) void change_mnt_propagation(struct mount *, int); int propagate_mnt(struct mount *, struct mountpoint *, struct mount *, - struct list_head *); -int propagate_umount(struct list_head *); + struct hlist_head *); +int propagate_umount(struct hlist_head *); int propagate_mount_busy(struct mount *, int); void mnt_release_group_id(struct mount *); int get_dominating_id(struct mount *mnt, const struct path *root); |