summaryrefslogtreecommitdiffstats
path: root/fs/proc/vmcore.c
diff options
context:
space:
mode:
authorKOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>2011-05-27 01:25:52 +0200
committerLinus Torvalds <torvalds@linux-foundation.org>2011-05-27 02:12:37 +0200
commit30cd8903913dac7b0918807cac46be3ecde5a5a7 (patch)
tree64022195d9a384c11b93a4b1299aa944b8293deb /fs/proc/vmcore.c
parentproc/stat: use defined macro KMALLOC_MAX_SIZE (diff)
downloadlinux-30cd8903913dac7b0918807cac46be3ecde5a5a7.tar.xz
linux-30cd8903913dac7b0918807cac46be3ecde5a5a7.zip
proc: put check_mem_permission after __get_free_page in mem_write
It whould be better if put check_mem_permission after __get_free_page in mem_write, to be same as function mem_read. Hugh Dickins explained the reason. check_mem_permission gets a reference to the mm. If we __get_free_page after check_mem_permission, imagine what happens if the system is out of memory, and the mm we're looking at is selected for killing by the OOM killer: while we wait in __get_free_page for more memory, no memory is freed from the selected mm because it cannot reach exit_mmap while we hold that reference. Reported-by: Jovi Zhang <bookjovi@gmail.com> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Acked-by: Hugh Dickins <hughd@google.com> Reviewed-by: Stephen Wilson <wilsons@start.ca> Cc: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/proc/vmcore.c')
0 files changed, 0 insertions, 0 deletions