summaryrefslogtreecommitdiffstats
path: root/fs/proc
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2014-09-30 01:08:25 +0200
committerSteven Rostedt <rostedt@goodmis.org>2014-11-05 20:13:23 +0100
commita3816ab0e8fe542a89a53b82506a8ddac063fbe3 (patch)
treeffbc4ef9fe5deb6c9af3473055e0854078e1c7aa /fs/proc
parentdlm: Use seq_puts() instead of seq_printf() for constant strings (diff)
downloadlinux-a3816ab0e8fe542a89a53b82506a8ddac063fbe3.tar.xz
linux-a3816ab0e8fe542a89a53b82506a8ddac063fbe3.zip
fs: Convert show_fdinfo functions to void
seq_printf functions shouldn't really check the return value. Checking seq_has_overflowed() occasionally is used instead. Update vfs documentation. Link: http://lkml.kernel.org/p/e37e6e7b76acbdcc3bb4ab2a57c8f8ca1ae11b9a.1412031505.git.joe@perches.com Cc: David S. Miller <davem@davemloft.net> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Joe Perches <joe@perches.com> [ did a few clean ups ] Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'fs/proc')
-rw-r--r--fs/proc/fd.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/proc/fd.c b/fs/proc/fd.c
index e11d7c590bb0..8e5ad83b629a 100644
--- a/fs/proc/fd.c
+++ b/fs/proc/fd.c
@@ -53,7 +53,8 @@ static int seq_show(struct seq_file *m, void *v)
(long long)file->f_pos, f_flags,
real_mount(file->f_path.mnt)->mnt_id);
if (file->f_op->show_fdinfo)
- ret = file->f_op->show_fdinfo(m, file);
+ file->f_op->show_fdinfo(m, file);
+ ret = seq_has_overflowed(m);
fput(file);
}