diff options
| author | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-07-17 20:37:07 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-07-17 21:15:30 +0200 |
| commit | 67a101f573b0cb1043c8c305112113450cb9fdbf (patch) | |
| tree | a7683be1ef70c4843c82ac5981f15e79033f33d6 /fs/pstore | |
| parent | Staging: ipack: change naming convention in TODO file (diff) | |
| download | linux-67a101f573b0cb1043c8c305112113450cb9fdbf.tar.xz linux-67a101f573b0cb1043c8c305112113450cb9fdbf.zip | |
pstore: Headers should include all stuff they use
Headers should really include all the needed prototypes, types, defines
etc. to be self-contained. This is a long-standing issue, but apparently
the new tracing code unearthed it (SMP=n is also a prerequisite):
In file included from fs/pstore/internal.h:4:0,
from fs/pstore/ftrace.c:21:
include/linux/pstore.h:43:15: error: field ‘read_mutex’ has incomplete type
While at it, I also added the following:
linux/types.h -> size_t, phys_addr_t, uXX and friends
linux/spinlock.h -> spinlock_t
linux/errno.h -> Exxxx
linux/time.h -> struct timespec (struct passed by value)
struct module and rs_control forward declaration (passed via pointers).
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/pstore')
| -rw-r--r-- | fs/pstore/internal.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/pstore/internal.h b/fs/pstore/internal.h index 958c48d8905c..0d0d3b7d5f12 100644 --- a/fs/pstore/internal.h +++ b/fs/pstore/internal.h @@ -1,6 +1,8 @@ #ifndef __PSTORE_INTERNAL_H__ #define __PSTORE_INTERNAL_H__ +#include <linux/types.h> +#include <linux/time.h> #include <linux/pstore.h> #if NR_CPUS <= 2 && defined(CONFIG_ARM_THUMB) |