diff options
| author | Nikolay Borisov <kernel@kyup.com> | 2016-03-03 10:54:57 +0100 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2016-03-03 11:01:58 +0100 |
| commit | ab73ef46398e2c0159f3a71de834586422d2a44a (patch) | |
| tree | 4388f22e3f80dbf4b702e90c7e71467fedcd5ea3 /fs/quota | |
| parent | ext4: Make Q_GETNEXTQUOTA work for quota in hidden inodes (diff) | |
| download | linux-ab73ef46398e2c0159f3a71de834586422d2a44a.tar.xz linux-ab73ef46398e2c0159f3a71de834586422d2a44a.zip | |
quota: Fix possible GPF due to uninitialised pointers
When dqget() in __dquot_initialize() fails e.g. due to IO error,
__dquot_initialize() will pass an array of uninitialized pointers to
dqput_all() and thus can lead to deference of random data. Fix the
problem by properly initializing the array.
CC: stable@vger.kernel.org
Signed-off-by: Nikolay Borisov <kernel@kyup.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/quota')
| -rw-r--r-- | fs/quota/dquot.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index e8467dc90c7e..dcec1edf579f 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -1410,7 +1410,7 @@ static int dquot_active(const struct inode *inode) static int __dquot_initialize(struct inode *inode, int type) { int cnt, init_needed = 0; - struct dquot **dquots, *got[MAXQUOTAS]; + struct dquot **dquots, *got[MAXQUOTAS] = {}; struct super_block *sb = inode->i_sb; qsize_t rsv; int ret = 0; @@ -1427,7 +1427,6 @@ static int __dquot_initialize(struct inode *inode, int type) int rc; struct dquot *dquot; - got[cnt] = NULL; if (type != -1 && cnt != type) continue; /* |