summaryrefslogtreecommitdiffstats
path: root/fs/quota
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2017-06-08 15:43:13 +0200
committerJan Kara <jack@suse.cz>2017-08-17 19:01:16 +0200
commit47cdc11deed639ae1d4050efbc284d328c3c2fa5 (patch)
tree288702be32fe962ae34b7abd386eaa2dc25ccb9a /fs/quota
parentquota: Push dqio_sem down to ->read_dqblk() (diff)
downloadlinux-47cdc11deed639ae1d4050efbc284d328c3c2fa5.tar.xz
linux-47cdc11deed639ae1d4050efbc284d328c3c2fa5.zip
quota: Remove locking for reading from the old quota format
The old quota format has fixed offset in quota file based on ID so there's no locking needed against concurrent modifications of the file (locking against concurrent IO on the same dquot is still provided by dq_lock). Reviewed-by: Andreas Dilger <adilger@dilger.ca> Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/quota')
-rw-r--r--fs/quota/quota_v1.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/quota/quota_v1.c b/fs/quota/quota_v1.c
index d534c4043237..12d69cda57cc 100644
--- a/fs/quota/quota_v1.c
+++ b/fs/quota/quota_v1.c
@@ -61,7 +61,6 @@ static int v1_read_dqblk(struct dquot *dquot)
if (!dqopt->files[type])
return -EINVAL;
- down_read(&dqopt->dqio_sem);
/* Set structure to 0s in case read fails/is after end of file */
memset(&dqblk, 0, sizeof(struct v1_disk_dqblk));
dquot->dq_sb->s_op->quota_read(dquot->dq_sb, type, (char *)&dqblk,
@@ -75,7 +74,6 @@ static int v1_read_dqblk(struct dquot *dquot)
dquot->dq_dqb.dqb_isoftlimit == 0)
set_bit(DQ_FAKE_B, &dquot->dq_flags);
dqstats_inc(DQST_READS);
- up_read(&dqopt->dqio_sem);
return 0;
}