summaryrefslogtreecommitdiffstats
path: root/fs/ramfs/inode.c
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2019-05-29 07:40:26 +0200
committerDavid S. Miller <davem@davemloft.net>2019-05-30 20:51:29 +0200
commit32707c4dfa20b01d6a3c8d2797daa52bfc188add (patch)
tree14d57d834cd97a5dd58b8ef0cb44847f83fb45ac /fs/ramfs/inode.c
parentnet: mvpp2: cls: Remove unnessesary check in mvpp2_ethtool_cls_rule_ins (diff)
downloadlinux-32707c4dfa20b01d6a3c8d2797daa52bfc188add.tar.xz
linux-32707c4dfa20b01d6a3c8d2797daa52bfc188add.zip
inet: frags: Remove unnecessary smp_store_release/READ_ONCE
The smp_store_release call in fqdir_exit cannot protect the setting of fqdir->dead as claimed because its memory barrier is only guaranteed to be one-way and the barrier precedes the setting of fqdir->dead. IOW it doesn't provide any barriers between fq->dir and the following hash table destruction. In fact, the code is safe anyway because call_rcu does provide both the memory barrier as well as a guarantee that when the destruction work starts executing all RCU readers will see the updated value for fqdir->dead. Therefore this patch removes the unnecessary smp_store_release call as well as the corresponding READ_ONCE on the read-side in order to not confuse future readers of this code. Comments have been added in their places. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'fs/ramfs/inode.c')
0 files changed, 0 insertions, 0 deletions