diff options
| author | David Howells <dhowells@redhat.com> | 2009-04-23 17:41:13 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-04-24 22:28:31 +0200 |
| commit | 84baf74bf23bbe9f3deafb5d2f27e2b5dc0bc052 (patch) | |
| tree | 45af84d051ca760a9f9f24aa3775e5505ccd3627 /fs/romfs/internal.h | |
| parent | lib: find_last_bit.o needed by a module only, move it from lib to obj (diff) | |
| download | linux-84baf74bf23bbe9f3deafb5d2f27e2b5dc0bc052.tar.xz linux-84baf74bf23bbe9f3deafb5d2f27e2b5dc0bc052.zip | |
ROMFS: romfs_lookup() shouldn't be doing a partial name comparison
romfs_lookup() should be using a routine akin to strcmp() on the backing store,
rather than one akin to strncmp(). If it uses the latter, it's liable to match
/bin/shutdown when looking up /bin/sh.
Signed-off-by: David Howells <dhowells@redhat.com>
Tested-by: Michal Simek <monstr@monstr.eu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/romfs/internal.h')
| -rw-r--r-- | fs/romfs/internal.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/romfs/internal.h b/fs/romfs/internal.h index 06044a9dc62d..95217b830118 100644 --- a/fs/romfs/internal.h +++ b/fs/romfs/internal.h @@ -43,5 +43,5 @@ extern int romfs_dev_read(struct super_block *sb, unsigned long pos, void *buf, size_t buflen); extern ssize_t romfs_dev_strnlen(struct super_block *sb, unsigned long pos, size_t maxlen); -extern int romfs_dev_strncmp(struct super_block *sb, unsigned long pos, - const char *str, size_t size); +extern int romfs_dev_strcmp(struct super_block *sb, unsigned long pos, + const char *str, size_t size); |