summaryrefslogtreecommitdiffstats
path: root/fs/seq_file.c
diff options
context:
space:
mode:
authorAlexey Dobriyan <adobriyan@gmail.com>2009-02-05 22:30:05 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2009-02-05 23:18:14 +0100
commitf01d1d546abb2f4028b5299092f529eefb01253a (patch)
tree625a9f9923ae53cc9bf75cf46fcebbbeb8ac84a8 /fs/seq_file.c
parentseq_file: move traverse so it can be used from seq_read (diff)
downloadlinux-f01d1d546abb2f4028b5299092f529eefb01253a.tar.xz
linux-f01d1d546abb2f4028b5299092f529eefb01253a.zip
seq_file: fix big-enough lseek() + read()
lseek() further than length of the file will leave stale ->index (second-to-last during iteration). Next seq_read() will not notice that ->f_pos is big enough to return 0, but will print last item as if ->f_pos is pointing to it. Introduced in commit cb510b8172602a66467f3551b4be1911f5a7c8c2 aka "seq_file: more atomicity in traverse()". Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/seq_file.c')
-rw-r--r--fs/seq_file.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/seq_file.c b/fs/seq_file.c
index 2716c12eacf5..5267098532bf 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -102,6 +102,7 @@ static int traverse(struct seq_file *m, loff_t offset)
p = m->op->next(m, p, &index);
}
m->op->stop(m, p);
+ m->index = index;
return error;
Eoverflow: