summaryrefslogtreecommitdiffstats
path: root/fs/smb
diff options
context:
space:
mode:
authorMarios Makassikis <mmakassikis@freebox.fr>2024-04-15 15:12:48 +0200
committerSteve French <stfrench@microsoft.com>2024-04-20 03:48:47 +0200
commit4973b04d3ea577db80c501c5f14e68ec69fe1794 (patch)
tree02abb20159bc53dfd75ed0d26edcd71ac95c0a19 /fs/smb
parentksmbd: validate request buffer size in smb2_allocate_rsp_buf() (diff)
downloadlinux-4973b04d3ea577db80c501c5f14e68ec69fe1794.tar.xz
linux-4973b04d3ea577db80c501c5f14e68ec69fe1794.zip
ksmbd: clear RENAME_NOREPLACE before calling vfs_rename
File overwrite case is explicitly handled, so it is not necessary to pass RENAME_NOREPLACE to vfs_rename. Clearing the flag fixes rename operations when the share is a ntfs-3g mount. The latter uses an older version of fuse with no support for flags in the ->rename op. Cc: stable@vger.kernel.org Signed-off-by: Marios Makassikis <mmakassikis@freebox.fr> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/smb')
-rw-r--r--fs/smb/server/vfs.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c
index 22f0f3db3ac9..51b1b0bed616 100644
--- a/fs/smb/server/vfs.c
+++ b/fs/smb/server/vfs.c
@@ -754,10 +754,15 @@ retry:
goto out4;
}
+ /*
+ * explicitly handle file overwrite case, for compatibility with
+ * filesystems that may not support rename flags (e.g: fuse)
+ */
if ((flags & RENAME_NOREPLACE) && d_is_positive(new_dentry)) {
err = -EEXIST;
goto out4;
}
+ flags &= ~(RENAME_NOREPLACE);
if (old_child == trap) {
err = -EINVAL;