diff options
author | Corey Minyard <minyard@acm.org> | 2014-01-22 00:48:44 +0100 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-01-22 01:19:42 +0100 |
commit | 4e4f9e66a75921aa260c2f5bf626bdea54e51ba2 (patch) | |
tree | 90c9fe3508062f8056b727aaff577d444f6b55e9 /fs/super.c | |
parent | fs/compat_ioctl.c: fix an underflow issue (harmless) (diff) | |
download | linux-4e4f9e66a75921aa260c2f5bf626bdea54e51ba2.tar.xz linux-4e4f9e66a75921aa260c2f5bf626bdea54e51ba2.zip |
fs/read_write.c:compat_readv(): remove bogus area verify
The compat_do_readv_writev() function was doing a verify_area on the
incoming iov, but the nr_segs value is not checked. If someone passes
in a -1 for nr_segs, for instance, the function should return an EINVAL.
However, it returns a EFAULT because the verify_area fails because it is
checking an array of size MAX_UINT. The check is bogus, anyway, because
the next check, compat_rw_copy_check_uvector(), will do all the
necessary checking, anyway. The non-compat do_readv_writev() function
doesn't do this check, so I think it's safe to just remove the code.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/super.c')
0 files changed, 0 insertions, 0 deletions