diff options
| author | Christian Brauner <brauner@kernel.org> | 2023-11-04 15:00:12 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2023-11-18 14:59:24 +0100 |
| commit | efa5d065b4a0790061921194019c321ad335b8db (patch) | |
| tree | d967a1647729a43ec4e70936773d8b10ad284a3a /fs/super.c | |
| parent | nilfs2: simplify device handling (diff) | |
| download | linux-efa5d065b4a0790061921194019c321ad335b8db.tar.xz linux-efa5d065b4a0790061921194019c321ad335b8db.zip | |
fs: remove dead check
Above we call super_lock_excl() which waits until the superblock is
SB_BORN and since SB_BORN is never unset once set this check can never
fire. Plus, we also hold an active reference at this point already so
this superblock can't even be shutdown.
Link: https://lore.kernel.org/r/20231104-vfs-multi-device-freeze-v2-1-5b5b69626eac@kernel.org
Tested-by: Chandan Babu R <chandanbabu@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/super.c')
| -rw-r--r-- | fs/super.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/fs/super.c b/fs/super.c index faeab453e6e9..d2b026566dea 100644 --- a/fs/super.c +++ b/fs/super.c @@ -1996,11 +1996,6 @@ retry: goto retry; } - if (!(sb->s_flags & SB_BORN)) { - super_unlock_excl(sb); - return 0; /* sic - it's "nothing to do" */ - } - if (sb_rdonly(sb)) { /* Nothing to do really... */ sb->s_writers.freeze_holders |= who; |