diff options
| author | Thomas Maier <balagi@justmail.de> | 2006-10-22 19:17:47 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2006-12-01 23:52:01 +0100 |
| commit | 035ed7a49447bc8e15d4d9316fc6a359b2d94333 (patch) | |
| tree | 2607c8c03a719e4aa4bbbe46ca4ee3eb490755b5 /fs/sysfs | |
| parent | cpu topology: consider sysfs_create_group return value (diff) | |
| download | linux-035ed7a49447bc8e15d4d9316fc6a359b2d94333.tar.xz linux-035ed7a49447bc8e15d4d9316fc6a359b2d94333.zip | |
sysfs: sysfs_write_file() writes zero terminated data
since most of the files in sysfs are text files,
it would be nice, if the "store" function called
during sysfs_write_file() gets a zero terminated
string / data.
The current implementation seems not to ensure this.
(But only if it is the first time the zeroed buffer
page is allocated.)
So the buffer can be scanned by sscanf() easily,
for example.
This patch simply sets a \0 char behind the
data in buffer->page.
Signed-off-by: Thomas Maier <balagi@justmail.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs/sysfs')
| -rw-r--r-- | fs/sysfs/file.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 298303b5a716..95c165101c98 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -190,6 +190,9 @@ fill_write_buffer(struct sysfs_buffer * buffer, const char __user * buf, size_t count = PAGE_SIZE - 1; error = copy_from_user(buffer->page,buf,count); buffer->needs_read_fill = 1; + /* if buf is assumed to contain a string, terminate it by \0, + so e.g. sscanf() can scan the string easily */ + buffer->page[count] = 0; return error ? -EFAULT : count; } |