diff options
| author | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2009-01-29 15:22:54 +0100 |
|---|---|---|
| committer | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2009-01-29 15:22:54 +0100 |
| commit | a2b9df3ff691db8e5e521dccd231a8098bbf7416 (patch) | |
| tree | 50a12bd4d40a27d7a605aa55e3d770b4af3c8576 /fs/ubifs/master.c | |
| parent | UBIFS: remount ro fixes (diff) | |
| download | linux-a2b9df3ff691db8e5e521dccd231a8098bbf7416.tar.xz linux-a2b9df3ff691db8e5e521dccd231a8098bbf7416.zip | |
UBIFS: return sensible error codes
When mounting/re-mounting, UBIFS returns EINVAL even if the ENOSPC
or EROFS codes are are much better, just because we have not found
references to ENOSPC/EROFS in mount (2) man pages. This patch
changes this behaviour and makes UBIFS return real error code,
because:
1. It is just less confusing and more logical
2. mount is not described in SuSv3, so it seems to be not really
well-standartized
3. we do not cover all cases, and any random undocumented in man
pages error code may be returned anyway
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Diffstat (limited to 'fs/ubifs/master.c')
| -rw-r--r-- | fs/ubifs/master.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ubifs/master.c b/fs/ubifs/master.c index 71d5493bf565..a88f33801b98 100644 --- a/fs/ubifs/master.c +++ b/fs/ubifs/master.c @@ -354,7 +354,7 @@ int ubifs_write_master(struct ubifs_info *c) int err, lnum, offs, len; if (c->ro_media) - return -EINVAL; + return -EROFS; lnum = UBIFS_MST_LNUM; offs = c->mst_offs + c->mst_node_alsz; |