summaryrefslogtreecommitdiffstats
path: root/fs/ubifs/tnc_commit.c
diff options
context:
space:
mode:
authorArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2011-03-29 17:19:50 +0200
committerArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2011-05-13 18:23:53 +0200
commit8ff83089f8bcbd9a2e898b68f1a46487c8b6e38c (patch)
tree36b286946894a4b797d850cca67603cac89ec1f2 /fs/ubifs/tnc_commit.c
parentUBIFS: introduce a separate structure for budgeting info (diff)
downloadlinux-8ff83089f8bcbd9a2e898b68f1a46487c8b6e38c.tar.xz
linux-8ff83089f8bcbd9a2e898b68f1a46487c8b6e38c.zip
UBIFS: simplify dbg_dump_budg calling conventions
The current 'dbg_dump_budg()' calling convention is that the 'c->space_lock' spinlock is held. However, none of the callers actually use it from contects which have 'c->space_lock' locked, so all callers have to explicitely lock and unlock the spinlock. This is not very sensible convention. This patch changes it and makes 'dbg_dump_budg()' lock the spinlock instead of imposing this to the callers. This simplifies the code a little. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Diffstat (limited to 'fs/ubifs/tnc_commit.c')
-rw-r--r--fs/ubifs/tnc_commit.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ubifs/tnc_commit.c b/fs/ubifs/tnc_commit.c
index 9c376b9e74ff..66f066de2c57 100644
--- a/fs/ubifs/tnc_commit.c
+++ b/fs/ubifs/tnc_commit.c
@@ -383,9 +383,7 @@ static int layout_in_gaps(struct ubifs_info *c, int cnt)
* option which forces in-the-gaps is enabled.
*/
ubifs_err("out of space");
- spin_lock(&c->space_lock);
dbg_dump_budg(c);
- spin_unlock(&c->space_lock);
dbg_dump_lprops(c);
}
/* Try to commit anyway */