summaryrefslogtreecommitdiffstats
path: root/fs/ubifs
diff options
context:
space:
mode:
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>2014-05-27 14:24:39 +0200
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>2014-05-28 10:10:09 +0200
commitba6a7d55634b9ddf119216faef55f2463b17d60b (patch)
tree38168863021d503094ec8f5d7527527e11bfed76 /fs/ubifs
parentUBIFS: add missing ui pointer in debugging code (diff)
downloadlinux-ba6a7d55634b9ddf119216faef55f2463b17d60b.tar.xz
linux-ba6a7d55634b9ddf119216faef55f2463b17d60b.zip
UBIFS: fix debugging check
The debugging check which verifies that we never write outside of the file length was incorrect, since it was multiplying file length by the page size, instead of dividing. Fix this. Spotted-by: hujianyang <hujianyang@huawei.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Diffstat (limited to 'fs/ubifs')
-rw-r--r--fs/ubifs/file.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
index 727506b5e2ea..0ab7f7dfb98b 100644
--- a/fs/ubifs/file.c
+++ b/fs/ubifs/file.c
@@ -905,7 +905,7 @@ static int do_writepage(struct page *page, int len)
#ifdef UBIFS_DEBUG
struct ubifs_inode *ui = ubifs_inode(inode);
spin_lock(&ui->ui_lock);
- ubifs_assert(page->index <= ui->synced_i_size << PAGE_CACHE_SIZE);
+ ubifs_assert(page->index <= ui->synced_i_size >> PAGE_CACHE_SHIFT);
spin_unlock(&ui->ui_lock);
#endif