diff options
| author | Eric Biggers <ebiggers@google.com> | 2020-12-03 03:20:35 +0100 |
|---|---|---|
| committer | Eric Biggers <ebiggers@google.com> | 2020-12-03 03:25:01 +0100 |
| commit | a302052b9586f2fdf8c3a7d9b907e71b25d7d463 (patch) | |
| tree | 0b644e05ca9c38bb199295dbf1447b0e3e94090f /fs/ubifs | |
| parent | f2fs: remove f2fs_dir_open() (diff) | |
| download | linux-a302052b9586f2fdf8c3a7d9b907e71b25d7d463.tar.xz linux-a302052b9586f2fdf8c3a7d9b907e71b25d7d463.zip | |
ubifs: remove ubifs_dir_open()
Since encrypted directories can be opened and searched without their key
being available, and each readdir and ->lookup() tries to set up the
key, trying to set up the key in ->open() too isn't really useful.
Just remove it so that directories don't need an ->open() method
anymore, and so that we eliminate a use of fscrypt_get_encryption_info()
(which I'd like to stop exporting to filesystems).
Link: https://lore.kernel.org/r/20201203022041.230976-4-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Diffstat (limited to 'fs/ubifs')
| -rw-r--r-- | fs/ubifs/dir.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index 08fde777c324..009fbf844d3e 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c @@ -1619,14 +1619,6 @@ int ubifs_getattr(const struct path *path, struct kstat *stat, return 0; } -static int ubifs_dir_open(struct inode *dir, struct file *file) -{ - if (IS_ENCRYPTED(dir)) - return fscrypt_get_encryption_info(dir) ? -EACCES : 0; - - return 0; -} - const struct inode_operations ubifs_dir_inode_operations = { .lookup = ubifs_lookup, .create = ubifs_create, @@ -1653,7 +1645,6 @@ const struct file_operations ubifs_dir_operations = { .iterate_shared = ubifs_readdir, .fsync = ubifs_fsync, .unlocked_ioctl = ubifs_ioctl, - .open = ubifs_dir_open, #ifdef CONFIG_COMPAT .compat_ioctl = ubifs_compat_ioctl, #endif |