diff options
author | Steve Magnani <steve.magnani@digidescorp.com> | 2017-10-12 15:48:41 +0200 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2017-10-17 12:00:58 +0200 |
commit | fcbf7637e6647e00de04d4b2e05ece2484bb3062 (patch) | |
tree | 438535f802620428f7f42c6f44153b5fc5bfe29b /fs/udf/misc.c | |
parent | udf: Fix 64-bit sign extension issues affecting blocks > 0x7FFFFFFF (diff) | |
download | linux-fcbf7637e6647e00de04d4b2e05ece2484bb3062.tar.xz linux-fcbf7637e6647e00de04d4b2e05ece2484bb3062.zip |
udf: Fix signed/unsigned format specifiers
Fix problems noted in compilion with -Wformat=2 -Wformat-signedness.
In particular, a mismatch between the signedness of a value and the
signedness of its format specifier can result in unsigned values being
printed as negative numbers, e.g.:
Partition (0 type 1511) starts at physical 460, block length -1779968542
...which occurs when mounting a large (> 1 TiB) UDF partition.
Changes since V1:
* Fixed additional issues noted in udf_bitmap_free_blocks(),
udf_get_fileident(), udf_show_options()
Signed-off-by: Steven J. Magnani <steve@digidescorp.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/udf/misc.c')
-rw-r--r-- | fs/udf/misc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/udf/misc.c b/fs/udf/misc.c index 97f3258a7483..401e64cde1be 100644 --- a/fs/udf/misc.c +++ b/fs/udf/misc.c @@ -209,7 +209,7 @@ struct buffer_head *udf_read_tagged(struct super_block *sb, uint32_t block, bh = udf_tread(sb, block); if (!bh) { - udf_err(sb, "read failed, block=%u, location=%d\n", + udf_err(sb, "read failed, block=%u, location=%u\n", block, location); return NULL; } @@ -247,7 +247,7 @@ struct buffer_head *udf_read_tagged(struct super_block *sb, uint32_t block, le16_to_cpu(tag_p->descCRCLength))) return bh; - udf_debug("Crc failure block %d: crc = %d, crclen = %d\n", block, + udf_debug("Crc failure block %u: crc = %u, crclen = %u\n", block, le16_to_cpu(tag_p->descCRC), le16_to_cpu(tag_p->descCRCLength)); error_out: |