diff options
| author | Eric Biggers <ebiggers@google.com> | 2023-07-05 23:27:42 +0200 |
|---|---|---|
| committer | Eric Biggers <ebiggers@google.com> | 2023-07-12 07:49:18 +0200 |
| commit | e77000ccc531088c486fe5fbd13416fd5e3d2714 (patch) | |
| tree | cc75f2c75caa4054a06635125884bf67210aa066 /fs/verity/open.c | |
| parent | fsverity: explicitly check that there is no algorithm 0 (diff) | |
| download | linux-e77000ccc531088c486fe5fbd13416fd5e3d2714.tar.xz linux-e77000ccc531088c486fe5fbd13416fd5e3d2714.zip | |
fsverity: simplify handling of errors during initcall
Since CONFIG_FS_VERITY is a bool, not a tristate, fs/verity/ can only be
builtin or absent entirely; it can't be a loadable module. Therefore,
the error code that gets returned from the fsverity_init() initcall is
never used. If any part of the initcall does fail, which should never
happen, the kernel will be left in a bad state.
Following the usual convention for builtin code, just panic the kernel
if any of part of the initcall fails.
Link: https://lore.kernel.org/r/20230705212743.42180-2-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Diffstat (limited to 'fs/verity/open.c')
| -rw-r--r-- | fs/verity/open.c | 18 |
1 files changed, 5 insertions, 13 deletions
diff --git a/fs/verity/open.c b/fs/verity/open.c index 1db5106a9c38..6c31a871b84b 100644 --- a/fs/verity/open.c +++ b/fs/verity/open.c @@ -408,18 +408,10 @@ void __fsverity_cleanup_inode(struct inode *inode) } EXPORT_SYMBOL_GPL(__fsverity_cleanup_inode); -int __init fsverity_init_info_cache(void) +void __init fsverity_init_info_cache(void) { - fsverity_info_cachep = KMEM_CACHE_USERCOPY(fsverity_info, - SLAB_RECLAIM_ACCOUNT, - file_digest); - if (!fsverity_info_cachep) - return -ENOMEM; - return 0; -} - -void __init fsverity_exit_info_cache(void) -{ - kmem_cache_destroy(fsverity_info_cachep); - fsverity_info_cachep = NULL; + fsverity_info_cachep = KMEM_CACHE_USERCOPY( + fsverity_info, + SLAB_RECLAIM_ACCOUNT | SLAB_PANIC, + file_digest); } |