diff options
| author | Christoph Hellwig <hch@infradead.org> | 2010-02-15 23:02:19 +0100 |
|---|---|---|
| committer | Alex Elder <aelder@sgi.com> | 2010-03-01 23:35:17 +0100 |
| commit | f7008d0aeba21396b3422df135b692ae701bd0c8 (patch) | |
| tree | 6c51cbd3f7377f0394551988ce3b646fe2b31133 /fs/xfs/linux-2.6/xfs_trace.c | |
| parent | xfs: fix inode pincount check in fsync (diff) | |
| download | linux-f7008d0aeba21396b3422df135b692ae701bd0c8.tar.xz linux-f7008d0aeba21396b3422df135b692ae701bd0c8.zip | |
xfs: fix xfs_fsblock_t tracing
Using a static buffer in xfs_fmtfsblock means we can corrupt traces if
multiple CPUs hit this code path at the same. Just remove xfs_fmtfsblock
for now and print the block number purely numerical. If we want the
NULLFSBLOCK and NULLSTARTBLOCK formatting back the best way would be
a decoding plugin in the trace-cmd userspace command.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
Diffstat (limited to 'fs/xfs/linux-2.6/xfs_trace.c')
| -rw-r--r-- | fs/xfs/linux-2.6/xfs_trace.c | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/fs/xfs/linux-2.6/xfs_trace.c b/fs/xfs/linux-2.6/xfs_trace.c index 856eb3c8d605..5a107601e969 100644 --- a/fs/xfs/linux-2.6/xfs_trace.c +++ b/fs/xfs/linux-2.6/xfs_trace.c @@ -52,22 +52,6 @@ #include "quota/xfs_dquot.h" /* - * Format fsblock number into a static buffer & return it. - */ -STATIC char *xfs_fmtfsblock(xfs_fsblock_t bno) -{ - static char rval[50]; - - if (bno == NULLFSBLOCK) - sprintf(rval, "NULLFSBLOCK"); - else if (isnullstartblock(bno)) - sprintf(rval, "NULLSTARTBLOCK(%lld)", startblockval(bno)); - else - sprintf(rval, "%lld", (xfs_dfsbno_t)bno); - return rval; -} - -/* * We include this last to have the helpers above available for the trace * event implementations. */ |