diff options
| author | Christoph Hellwig <hch@infradead.org> | 2009-08-17 02:36:34 +0200 |
|---|---|---|
| committer | Felix Blyakher <felixb@sgi.com> | 2009-08-17 08:23:48 +0200 |
| commit | bc990f5cb424cdca9dda866785d088e2c2110ecc (patch) | |
| tree | 4264beb9538533d136e41f0e93933160fe925008 /fs/xfs/xfs_btree.h | |
| parent | dm-log-userspace: fix printk format warning (diff) | |
| download | linux-bc990f5cb424cdca9dda866785d088e2c2110ecc.tar.xz linux-bc990f5cb424cdca9dda866785d088e2c2110ecc.zip | |
xfs: fix locking in xfs_iget_cache_hit
The locking in xfs_iget_cache_hit currently has numerous problems:
- we clear the reclaim tag without i_flags_lock which protects
modifications to it
- we call inode_init_always which can sleep with pag_ici_lock
held (this is oss.sgi.com BZ #819)
- we acquire and drop i_flags_lock a lot and thus provide no
consistency between the various flags we set/clear under it
This patch fixes all that with a major revamp of the locking in
the function. The new version acquires i_flags_lock early and
only drops it once we need to call into inode_init_always or before
calling xfs_ilock.
This patch fixes a bug seen in the wild where we race modifying the
reclaim tag.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Felix Blyakher <felixb@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_btree.h')
0 files changed, 0 insertions, 0 deletions