diff options
| author | Dave Chinner <dchinner@redhat.com> | 2011-12-21 01:07:42 +0100 |
|---|---|---|
| committer | Ben Myers <bpm@sgi.com> | 2012-01-03 18:39:55 +0100 |
| commit | b1c770c273a4787069306fc82aab245e9ac72e9d (patch) | |
| tree | 64337e4ec57722c40a4a9733ab046d5ece2a65f2 /fs/xfs/xfs_discard.c | |
| parent | xfs: mark the xfssyncd workqueue as non-reentrant (diff) | |
| download | linux-b1c770c273a4787069306fc82aab245e9ac72e9d.tar.xz linux-b1c770c273a4787069306fc82aab245e9ac72e9d.zip | |
xfs: fix endian conversion issue in discard code
When finding the longest extent in an AG, we read the value directly
out of the AGF buffer without endian conversion. This will give an
incorrect length, resulting in FITRIM operations potentially not
trimming everything that it should.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_discard.c')
| -rw-r--r-- | fs/xfs/xfs_discard.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c index 8a24f0c6c860..286a051f12cf 100644 --- a/fs/xfs/xfs_discard.c +++ b/fs/xfs/xfs_discard.c @@ -68,7 +68,7 @@ xfs_trim_extents( * Look up the longest btree in the AGF and start with it. */ error = xfs_alloc_lookup_le(cur, 0, - XFS_BUF_TO_AGF(agbp)->agf_longest, &i); + be32_to_cpu(XFS_BUF_TO_AGF(agbp)->agf_longest), &i); if (error) goto out_del_cursor; @@ -84,7 +84,7 @@ xfs_trim_extents( if (error) goto out_del_cursor; XFS_WANT_CORRUPTED_GOTO(i == 1, out_del_cursor); - ASSERT(flen <= XFS_BUF_TO_AGF(agbp)->agf_longest); + ASSERT(flen <= be32_to_cpu(XFS_BUF_TO_AGF(agbp)->agf_longest)); /* * Too small? Give up. |