diff options
author | Dave Chinner <dchinner@redhat.com> | 2013-05-20 01:51:09 +0200 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2013-05-24 23:27:41 +0200 |
commit | 7031d0e1c46e2b1c869458233dd216cb72af41b2 (patch) | |
tree | ea6b8690937f4a2129eafc176ee8adcaeb8f5293 /fs/xfs/xfs_extfree_item.c | |
parent | xfs: fix sub-page blocksize data integrity writes (diff) | |
download | linux-7031d0e1c46e2b1c869458233dd216cb72af41b2.tar.xz linux-7031d0e1c46e2b1c869458233dd216cb72af41b2.zip |
xfs: fix rounding in xfs_free_file_space
The offset passed into xfs_free_file_space() needs to be rounded
down to a certain size, but the rounding mask is built by a 32 bit
variable. Hence the mask will always mask off the upper 32 bits of
the offset and lead to incorrect writeback and invalidation ranges.
This is not actually exposed as a bug because we writeback and
invalidate from the rounded offset to the end of the file, and hence
the offset we are actually punching a hole out of will always be
covered by the code. This needs fixing, however, if we ever want to
use exact ranges for writeback/invalidation here...
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
(cherry picked from commit 28ca489c63e9aceed8801d2f82d731b3c9aa50f5)
Diffstat (limited to 'fs/xfs/xfs_extfree_item.c')
0 files changed, 0 insertions, 0 deletions