summaryrefslogtreecommitdiffstats
path: root/fs/xfs/xfs_ioctl32.c
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2020-01-08 00:25:37 +0100
committerDarrick J. Wong <darrick.wong@oracle.com>2020-01-09 19:55:18 +0100
commit953aa9d136f53e226448dbd801a905c28f8071bf (patch)
tree1a5df80de0c912b38da8efc3ddd600e02cf31563 /fs/xfs/xfs_ioctl32.c
parentxfs: remove shadow variable in xfs_btree_lshift (diff)
downloadlinux-953aa9d136f53e226448dbd801a905c28f8071bf.tar.xz
linux-953aa9d136f53e226448dbd801a905c28f8071bf.zip
xfs: clear kernel only flags in XFS_IOC_ATTRMULTI_BY_HANDLE
Don't allow passing arbitrary flags as they change behavior including memory allocation that the call stack is not prepared for. Fixes: ddbca70cc45c ("xfs: allocate xattr buffer on demand") Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to '')
-rw-r--r--fs/xfs/xfs_ioctl32.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/xfs/xfs_ioctl32.c b/fs/xfs/xfs_ioctl32.c
index a49bd80b2c3b..20b3edc10f48 100644
--- a/fs/xfs/xfs_ioctl32.c
+++ b/fs/xfs/xfs_ioctl32.c
@@ -450,6 +450,8 @@ xfs_compat_attrmulti_by_handle(
error = 0;
for (i = 0; i < am_hreq.opcount; i++) {
+ ops[i].am_flags &= ~ATTR_KERNEL_FLAGS;
+
ops[i].am_error = strncpy_from_user((char *)attr_name,
compat_ptr(ops[i].am_attrname),
MAXNAMELEN);