summaryrefslogtreecommitdiffstats
path: root/fs/xfs/xfs_pnfs.c
diff options
context:
space:
mode:
authorIra Weiny <ira.weiny@intel.com>2019-08-20 03:15:28 +0200
committerDarrick J. Wong <darrick.wong@oracle.com>2019-08-20 03:15:28 +0200
commitb68271609c4f16a79eae8069933f64345afcf888 (patch)
tree7be686cc76fcd54f05acd8a4734562fa8bff8b86 /fs/xfs/xfs_pnfs.c
parentxfs: fix reflink source file racing with directio writes (diff)
downloadlinux-b68271609c4f16a79eae8069933f64345afcf888.tar.xz
linux-b68271609c4f16a79eae8069933f64345afcf888.zip
fs/xfs: Fix return code of xfs_break_leased_layouts()
The parens used in the while loop would result in error being assigned the value 1 rather than the intended errno value. This is required to return -ETXTBSY from follow on break_layout() changes. Signed-off-by: Ira Weiny <ira.weiny@intel.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs/xfs_pnfs.c')
-rw-r--r--fs/xfs/xfs_pnfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_pnfs.c b/fs/xfs/xfs_pnfs.c
index 0c954cad7449..a339bd5fa260 100644
--- a/fs/xfs/xfs_pnfs.c
+++ b/fs/xfs/xfs_pnfs.c
@@ -32,7 +32,7 @@ xfs_break_leased_layouts(
struct xfs_inode *ip = XFS_I(inode);
int error;
- while ((error = break_layout(inode, false) == -EWOULDBLOCK)) {
+ while ((error = break_layout(inode, false)) == -EWOULDBLOCK) {
xfs_iunlock(ip, *iolock);
*did_unlock = true;
error = break_layout(inode, true);