diff options
| author | Christoph Hellwig <hch@infradead.org> | 2009-11-24 19:02:23 +0100 |
|---|---|---|
| committer | Alex Elder <aelder@sgi.com> | 2009-12-11 22:11:21 +0100 |
| commit | 6ad112bfb5af537e9e3103c807748bb4a99bbd9e (patch) | |
| tree | 783d7ea24d916914914287f696c1a957e495bd59 /fs/xfs/xfs_rw.c | |
| parent | xfs: remove IO_ISAIO (diff) | |
| download | linux-6ad112bfb5af537e9e3103c807748bb4a99bbd9e.tar.xz linux-6ad112bfb5af537e9e3103c807748bb4a99bbd9e.zip | |
xfs: simplify xfs_buf_get / xfs_buf_read interfaces
Currently the low-level buffer cache interfaces are highly confusing
as we have a _flags variant of each that does actually respect the
flags, and one without _flags which has a flags argument that gets
ignored and overriden with a default set. Given that very few places
use the default arguments get rid of the duplication and convert all
callers to pass the flags explicitly. Also remove the now confusing
_flags postfix.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_rw.c')
| -rw-r--r-- | fs/xfs/xfs_rw.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/xfs/xfs_rw.c b/fs/xfs/xfs_rw.c index 3f816ad7ff19..6fa10897d417 100644 --- a/fs/xfs/xfs_rw.c +++ b/fs/xfs/xfs_rw.c @@ -277,10 +277,10 @@ xfs_read_buf( xfs_buf_t *bp; int error; - if (flags) - bp = xfs_buf_read_flags(target, blkno, len, flags); - else - bp = xfs_buf_read(target, blkno, len, flags); + if (!flags) + flags = XBF_LOCK | XBF_MAPPED; + + bp = xfs_buf_read(target, blkno, len, flags); if (!bp) return XFS_ERROR(EIO); error = XFS_BUF_GETERROR(bp); |