diff options
| author | Chandan Babu R <chandan.babu@oracle.com> | 2022-03-29 08:14:00 +0200 |
|---|---|---|
| committer | Chandan Babu R <chandan.babu@oracle.com> | 2022-04-13 09:02:07 +0200 |
| commit | 83a21c18441f75aec64548692b52d34582b98a6a (patch) | |
| tree | d8163c99fb4ae8707be6cec9cf2211f00659a216 /fs/xfs/xfs_symlink.c | |
| parent | xfs: Introduce per-inode 64-bit extent counters (diff) | |
| download | linux-83a21c18441f75aec64548692b52d34582b98a6a.tar.xz linux-83a21c18441f75aec64548692b52d34582b98a6a.zip | |
xfs: Directory's data fork extent counter can never overflow
The maximum file size that can be represented by the data fork extent counter
in the worst case occurs when all extents are 1 block in length and each block
is 1KB in size.
With XFS_MAX_EXTCNT_DATA_FORK_SMALL representing maximum extent count and with
1KB sized blocks, a file can reach upto,
(2^31) * 1KB = 2TB
This is much larger than the theoretical maximum size of a directory
i.e. XFS_DIR2_SPACE_SIZE * 3 = ~96GB.
Since a directory's inode can never overflow its data fork extent counter,
this commit removes all the overflow checks associated with
it. xfs_dinode_verify() now performs a rough check to verify if a diretory's
data fork is larger than 96GB.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>
Diffstat (limited to '')
| -rw-r--r-- | fs/xfs/xfs_symlink.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/fs/xfs/xfs_symlink.c b/fs/xfs/xfs_symlink.c index affbedf78160..4145ba872547 100644 --- a/fs/xfs/xfs_symlink.c +++ b/fs/xfs/xfs_symlink.c @@ -226,11 +226,6 @@ xfs_symlink( goto out_trans_cancel; } - error = xfs_iext_count_may_overflow(dp, XFS_DATA_FORK, - XFS_IEXT_DIR_MANIP_CNT(mp)); - if (error) - goto out_trans_cancel; - /* * Allocate an inode for the symlink. */ |