diff options
author | Lachlan McIlroy <lachlan@sgi.com> | 2008-10-30 06:53:25 +0100 |
---|---|---|
committer | Lachlan McIlroy <lachlan@redback.melbourne.sgi.com> | 2008-11-10 07:43:23 +0100 |
commit | 9ccbece546cf836f67f6d9bb4bf2f70f7476cb2c (patch) | |
tree | 86b6b97537c46eb70555fbe8ffdc16e1ec8b69d0 /fs/xfs/xfs_trans_inode.c | |
parent | Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6 (diff) | |
download | linux-9ccbece546cf836f67f6d9bb4bf2f70f7476cb2c.tar.xz linux-9ccbece546cf836f67f6d9bb4bf2f70f7476cb2c.zip |
[XFS] Fix use-after-free with log and quotas
Destroying the quota stuff on unmount can access the log - ie
XFS_QM_DONE() ends up in xfs_dqunlock() which calls
xfs_trans_unlocked_item() and then xfs_log_move_tail(). By this time the
log has already been destroyed. Just move the cleanup of the quota code
earlier in xfs_unmountfs() before the call to xfs_log_unmount(). Moving
XFS_QM_DONE() up near XFS_QM_DQPURGEALL() seems like a good spot.
SGI-PV: 987086
SGI-Modid: xfs-linux-melb:xfs-kern:32148a
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Peter Leckie <pleckie@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_trans_inode.c')
0 files changed, 0 insertions, 0 deletions